netdev - Re: Why not refresh ipv6 local link address of a bridge when a new interface added to the bridge?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110926085117.1a749151@nehalam.linuxnetplumber.net>
Date:	Mon, 26 Sep 2011 08:51:17 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Xiong <bottomofstack@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: Why not refresh ipv6 local link address of a bridge when a new
 interface added to the bridge?

On Tue, 20 Sep 2011 10:39:31 +0800
Eric Xiong <bottomofstack@...il.com> wrote:

> Hi all:
> Sorry for disturb! when adding a interface to bridge, maybe the bridge
> mac address will be changed. the bridge code don't invoke
> call_netdevice_notifiers to notify ipv6 code to refresh local link
> address. I don't know why. Thanks for your help!
> 
> BRs.

This change went in for v3.1


    Bridge: Always send NETDEV_CHANGEADDR up on br MAC change.
    
    This ensures the neighbor entries associated with the bridge
    dev are flushed, also invalidating the associated cached L2 headers.
    
    This means we br_add_if/br_del_if ports to implement hand-over and
    not wind up with bridge packets going out with stale MAC.
    
    This means we can also change MAC of port device and also not wind
    up with bridge packets going out with stale MAC.
    
    This builds on Stephen Hemminger's patch, also handling the br_del_if
    case and the port MAC change case.
    
    Cc: Stephen Hemminger <shemminger@...tta.com>
    Signed-off-by: Andrei Warkentin <andreiw@...orola.com>
    Acked-by: Stephen Hemminger <shemminger@...tta.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html