netdev - Re: [PATCH net-next] tcp: unalias tcp_skb_cb flags and ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201109271138.00318.christoph.paasch@uclouvain.be>
Date:	Tue, 27 Sep 2011 11:38:00 +0300
From:	Christoph Paasch <christoph.paasch@...ouvain.be>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, hkchu@...gle.com,
	ilpo.jarvinen@...sinki.fi, jhs@...atatu.com
Subject: Re: [PATCH net-next] tcp: unalias tcp_skb_cb flags and ip_dsfield


On Tuesday 27 September 2011 wrote David Miller:
> From: Christoph Paasch <christoph.paasch@...ouvain.be>
> Date: Tue, 27 Sep 2011 10:37:38 +0300
> 
> > However, (as far as I can see) before Eric's change it was 42 bytes long
> > and now it became 43 bytes.
> 
> Then, I suggest that you go buy a pair of glasses. :-)

Yeah, maybe it's time to... ;-)

This two-byte hole, is it because "flags" and "sacked" are both __u8 and 
fields are aligned to 32-bit ?

Thanks,
Christoph

--
Christoph Paasch
PhD Student

IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://inl.info.ucl.ac.be/mptcp
Université Catholique de Louvain

www.rollerbulls.be
--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html