netdev - Re: [PATCH net-next] skge: handle irq better on single port card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110927.134158.473056454279800853.davem@davemloft.net>
Date:	Tue, 27 Sep 2011 13:41:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] skge: handle irq better on single port card

From: Stephen Hemminger <shemminger@...tta.com>
Date: Tue, 27 Sep 2011 10:25:23 -0700

> Most boards with SysKonnect/Marvell Ethernet have only a single port.
> For the single port case, use the standard Ethernet driver convention
> of allocating IRQ when device is brought up rather than at probe time.
> 
> This patch also adds some additional read after writes to avoid any
> PCI posting problems when setting the IRQ mask.
> 
> The error handling of dual port cards is also changed.  If second port
> can not be brought up, then just fail. No point in continuing, since
> the failure is most certainly because of out of memory.
> 
> It is worth noting that the dual port skge device has a single irq but two
> seperate status rings and therefore has two NAPI objects, one for
> each port.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html