netdev - Re: [RFC patch net-next-2.6] net: introduce ethernet teaming device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111001081534.GB1982@minipsycho.orion>
Date:	Sat, 1 Oct 2011 10:15:35 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	eric.dumazet@...il.com, bhutchings@...arflare.com,
	fubar@...ibm.com, andy@...yhouse.net, tgraf@...radead.org,
	ebiederm@...ssion.com, mirqus@...il.com, kaber@...sh.net,
	greearb@...delatech.com
Subject: Re: [RFC patch net-next-2.6] net: introduce ethernet teaming device

Fri, Sep 30, 2011 at 06:26:19PM CEST, shemminger@...tta.com wrote:
>On Fri, 30 Sep 2011 14:44:03 +0200
>Jiri Pirko <jpirko@...hat.com> wrote:
>
>> +static struct rtnl_link_stats64 *team_get_stats(struct net_device *dev,
>> +						struct rtnl_link_stats64 *stats)
>> +{
>> +	struct team *team = netdev_priv(dev);
>> +	struct rtnl_link_stats64 temp;
>> +	struct team_port *port;
>> +
>> +	memset(stats, 0, sizeof(*stats));
>> +
>> +	rcu_read_lock();
>> +	list_for_each_entry_rcu(port, &team->port_list, list) {
>> +		const struct rtnl_link_stats64 *pstats;
>
>You need to use u64_stats_sync macros to make this safe on 32 bit
>mode.

Well I'm doing this the same way it's done on several other place, as
for example bonding. 

>
>Also, I am not sure about the handling of speed and duplex.
>There are people who do active backup with links of different speeds.

Yes, team can handle multiple ifaces with different speeds and duplexes.
Why would you think it cannot?

>
>The team device doesn't seem to handle hardware offload features
>as completely as it should.  The TSO and transmit checksumming should
>be the union of the teamed ports.
>

Yeah, you are right here. I probably need something like
bond_compute_features() for team. Will add that.

Thank you Stephen.


Jirka

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html