netdev - Re: macvlan/macvtap patch in patchwork

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111002.203306.17836844704730738.davem@davemloft.net>
Date:	Sun, 02 Oct 2011 20:33:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	david.ward@...mit.edu
Cc:	kaber@...sh.net, netdev@...r.kernel.org,
	herbert@...dor.hengli.com.au, krkumar2@...ibm.com
Subject: Re: macvlan/macvtap patch in patchwork

From: "Ward, David - 0663 - MITLL" <david.ward@...mit.edu>
Date: Tue, 27 Sep 2011 19:11:00 -0400

> The problem is that I was forwarding the frame to the lowerdev the
> wrong way, by calling vlan->forward which serves a different purpose.
> vlan->forward points to dev_forward_skb for macvlan (so the forwarding
> works fine), but it points to macvtap_forward for macvtap (which
> causes an oops when called here).  We need to always use
> dev_forward_skb to forward to a lowerdev.

Thanks for explaining, patch applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html