netdev - [iproute2 PATCH 11/11] Fix file descriptor leak on error in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E89D3BC.5050206@intra2net.com>
Date:	Mon, 03 Oct 2011 17:24:44 +0200
From:	Thomas Jarosch <thomas.jarosch@...ra2net.com>
To:	netdev@...r.kernel.org
Subject: [iproute2 PATCH 11/11] Fix file descriptor leak on error in read_igmp()

Detected by cppcheck.

Signed-off-by: Thomas Jarosch <thomas.jarosch@...ra2net.com>
---
 ip/ipmaddr.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/ip/ipmaddr.c b/ip/ipmaddr.c
index 5a52c85..3ae9478 100644
--- a/ip/ipmaddr.c
+++ b/ip/ipmaddr.c
@@ -128,8 +128,10 @@ void read_igmp(struct ma_info **result_p)
 	if (!fp)
 		return;
 	memset(&m, 0, sizeof(m));
-	if (!fgets(buf, sizeof(buf), fp))
+	if (!fgets(buf, sizeof(buf), fp)) {
+		fclose(fp);
 		return;
+	}
 
 	m.addr.family = AF_INET;
 	m.addr.bitlen = 32;
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html