netdev - Re: [PATCH] bridge: Have tx_bytes count headers like rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1318032886.2771.149.camel@bwh-desktop>
Date:	Sat, 08 Oct 2011 01:14:46 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Ashish Sharma <ashishsharma@...gle.com>
Cc:	netdev@...r.kernel.org, jpa@...gle.com
Subject: Re: [PATCH] bridge: Have tx_bytes count headers like rx_bytes.

On Fri, 2011-10-07 at 13:47 -0700, Ashish Sharma wrote:
> Since rx_bytes accounting does not include Ethernet Headers in
> br_input.c, excluding ETH_HLEN on the transmit path for consistent
> measurement of packet length on both the Tx and Rx chains.
[...]

I think the TX path is correct in this regard, and the RX path should be
changed to include header length.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html