netdev - Re: [RFC] truesize lies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Oct 2011 17:27:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] truesize lies

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 09 Oct 2011 21:02:28 +0200

> I guess most driver writers adjust truesize to please TCP stack and get
> nice performance numbers.
> 
> skb->truesize = frame_len + sizeof(sk_buff);
> 
> What should we do exactly ?

We should pick a specification that accounts for all the metadata as well
as unused data areas properly, and enforce this in netif_receive_skb().

That will get the inaccurate cases fixed real fast.

We've had similar problems in the past and dealt with it in the same
exact way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html