netdev - Re: [PATCH] af_packet: tpacket_destruct_skb, deref skb after BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 18:06:24 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	danborkmann@...earbox.net
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] af_packet: tpacket_destruct_skb, deref skb after
 BUG_ON assertion

Le lundi 10 octobre 2011 à 10:02 +0200, danborkmann@...earbox.net a
écrit :

> Thanks, you're absolutely right! Here's the trivial patch:
> 
> af_packet: removed unnecessary BUG_ON assertion in tpacket_destruct_skb
> 

OK but a proper title should be 

[PATCH] af_packet: remove unnecessary BUG_ON() in tpacket_destruct_skb


> If skb is NULL, then stack trace is thrown on anyway on dereference.  
> Therefore,
> the stack trace triggered by BUG_ON is duplicate.
> 
> Signed-off-by: Daniel Borkmann <danborkmann@...glemail.com>
> 

missing "---" separator

> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index fabb4fa..886ae50 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -1170,8 +1170,6 @@ static void tpacket_destruct_skb(struct sk_buff *skb)
>   	struct packet_sock *po = pkt_sk(skb->sk);
>   	void *ph;
> 
> -	BUG_ON(skb == NULL);
> -
>   	if (likely(po->tx_ring.pg_vec)) {
>   		ph = skb_shinfo(skb)->destructor_arg;
>   		BUG_ON(__packet_get_status(po, ph) != TP_STATUS_SENDING);
> 
> 

Please send a complete new mail without any history.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html