netdev - Re: [PATCH] netconsole: enable netconsole can make net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E93F8DC.5080909@cn.fujitsu.com>
Date:	Tue, 11 Oct 2011 16:05:48 +0800
From:	Gao feng <gaofeng@...fujitsu.com>
To:	Wanlong Gao <gaowanlong@...fujitsu.com>
CC:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] netconsole: enable netconsole can make net_device refcnt

Im so sorry.
the first patch has some format err.
Please use this one.
thanks wanlong! ^V^

11.10.2011 15:50, Wanlong Gao wrote:
> There is no check if netconsole is enabled current.
> so when exec echo 1 > enabled;
> the reference of net_device will increment always.
> 
> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> ---
>  drivers/net/netconsole.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> index ed2a397..4e6323df 100644
> --- a/drivers/net/netconsole.c
> +++ b/drivers/net/netconsole.c
> @@ -307,6 +307,8 @@ static ssize_t store_enabled(struct netconsole_target *nt,
>  		return err;
>  	if (enabled < 0 || enabled > 1)
>  		return -EINVAL;
> +	if (enabled == nt->enabled)
> +		return err;
>  
>  	if (enabled) {	/* 1 */
>  

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html