netdev - Re: [net-next 1/5] stmmac: add CHAINED descriptor mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111011.154203.569015025155780686.davem@davemloft.net>
Date:	Tue, 11 Oct 2011 15:42:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, rayagond@...avyalabs.com
Subject: Re: [net-next 1/5] stmmac: add CHAINED descriptor mode support

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Tue, 11 Oct 2011 09:30:42 +0200

> From: Rayagond Kokatanur <rayagond@...avyalabs.com>
> 
> This patch enhances the STMMAC driver to support CHAINED mode of
> descriptor (useful also on validation side).
> 
> STMMAC supports DMA descriptor to operate both in dual buffer(RING)
> and linked-list(CHAINED) mode. In RING mode (default) each descriptor
> points to two data buffer pointers whereas in CHAINED mode they point
> to only one data buffer pointer.
> 
> In CHAINED mode each descriptor will have pointer to next descriptor in
> the list, hence creating the explicit chaining in the descriptor itself,
> whereas such explicit chaining is not possible in RING mode.
> 
> Signed-off-by: Rayagond Kokatanur <rayagond@...avyalabs.com>
> Hacked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

These ifdefs added all over the place in the foo.c files are terrible.

Abstract out the differences between RING and CHAINED mode into helper
inline routines which live in some foo.h header file, that way you won't
need any ifdefs in the driver foo.c files.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html