netdev - Re: [patch] cipso: remove an unneeded NULL check in cipso_v4_doi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1993964.1HBym86W0O@sifl>
Date:	Wed, 12 Oct 2011 17:28:08 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] cipso: remove an unneeded NULL check in cipso_v4_doi_add()

On Wednesday, October 12, 2011 12:55:49 AM Dan Carpenter wrote:
> On Tue, Oct 11, 2011 at 05:20:11PM -0400, Paul Moore wrote:
> > > -       if (doi_def == NULL || doi_def->doi == CIPSO_V4_DOI_UNKNOWN)
> > > +       if (doi_def->doi == CIPSO_V4_DOI_UNKNOWN)
> > >                goto doi_add_return;
> > >        for (iter = 0; iter < CIPSO_V4_TAG_MAXCNT; iter++) {
> > >                switch (doi_def->tags[iter]) {
> > 
> > I'd prefer to keep the NULL check in there as it does afford a little
> > bit of extra safety and this is management code after all, not
> > per-packet processing code, so the extra check should have no
> > observable performance impact.
> 
> The dereferences on the lines before mean we would Oops before
> reaching the check ...

Thanks for pointing that out, I missed that when looking at your patch.

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html