netdev - Re: [net-next 1/5] stmmac: add CHAINED descriptor mode support (V2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111013.163946.859494070937160730.davem@davemloft.net>
Date:	Thu, 13 Oct 2011 16:39:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, rayagond@...avyalabs.com
Subject: Re: [net-next 1/5] stmmac: add CHAINED descriptor mode support (V2)

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Wed, 12 Oct 2011 15:38:04 +0200

> +#if defined(CONFIG_STMMAC_RING)
> +
> +static unsigned int stmmac_jumbo_frm(struct stmmac_priv *priv,
> +				     struct sk_buff *skb, int csum_insertion)
> +{

This is not exactly what I meant.

In your original patch, two or three line snippets of code were conditionalized.

That's what I wanted you to do here.  Keep as much common code around as possible
in the driver *.c file, but the small 2 or 3 line conditional parts are implemented
in very small well contained inline functions implemented in a header file.

These small, 2 or 3 line, inline functions are where the ifdefs go.

I didn't mean to replicate all of the functions, in their entirety, into some
header file.

You might was well put the entire driver into a header file, then you can add
all the ifdefs you want :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html