netdev - Re: [PATCH net-next] skbuff: update sk truesize in pskb_expand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Oct 2011 11:54:38 +0800
From:	RongQing Li <roy.qing.li@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] skbuff: update sk truesize in pskb_expand_head

2011/10/14 Eric Dumazet <eric.dumazet@...il.com>:
> Le vendredi 14 octobre 2011 à 15:39 +0800, roy.qing.li@...il.com a
> écrit :
>
> I dont believe this is needed or complete patch.
>
> Callers that need an updated truesize do the adjustement.
>

If we think the size which needs to adjust is small, we can ignore it,
I accept it.

if Let caller to adjust it, I think the caller is hard to get the adjustment.

Do you think the below adjustment is needed?

void skb_add_rx_frag(struct sk_buff *skb, int i, struct page *page, int off,
		int size)
{
	skb_fill_page_desc(skb, i, page, off, size);
	skb->len += size;
	skb->data_len += size;
-	skb->truesize += size;
+	skb->truesize += PAGE_SIZE;
}

Thanks
-Qing
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html