netdev - Re: [PATCH] dev: use ifindex hash for dev_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZCWBhTy24WkWoC_wy11YuLxWQ3GWr3v1=JcGvprq4AtmA@mail.gmail.com>
Date:	Mon, 17 Oct 2011 11:03:54 +0300
From:	Daniel Baluta <dbaluta@...acom.com>
To:	Eric Dumazet <eric.dumazet@...il.com>, shemminger@...tta.com
Cc:	Mihai Maruseac <mihai.maruseac@...il.com>, davem@...emloft.net,
	mirq-linux@...e.qmqm.pl, therbert@...gle.com, jpirko@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mihai Maruseac <mmaruseac@...acom.com>
Subject: Re: [PATCH] dev: use ifindex hash for dev_seq_ops

> This assumes device ifindexes are contained in a small range
> [N .. N + X]
>
> I understand this can help some benchmarks, but in real world this wont
> help that much once ifindexes are 'fragmented' (If really this multi
> thousand devices stuff is for real)
>
> Listen, we currently have 256 slots in the hash table.
>
> Can we try to make 'offset' something like  (slot_number<<24) +
> (position in hash chain [slot_number]), instead of (position in devices
> global list)


Eric, we can refine the idea of our first patch [1], where we recorded
the (bucket, offset) pair. Stephen, do you agree with this?


thanks,
Daniel.

[1] http://patchwork.ozlabs.org/patch/118331/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html