netdev - Re: [PATCH] smsc911x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111017105256.GG5448@sirena.org.uk>
Date:	Mon, 17 Oct 2011 11:52:56 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Robert Marklund <robert.marklund@...ricsson.com>
Cc:	netdev@...r.kernel.org,
	Steve Glendinning <steve.glendinning@...c.com>,
	Mathieu Poirer <mathieu.poirier@...aro.org>
Subject: Re: [PATCH] smsc911x: Add regulator support

On Mon, Oct 17, 2011 at 08:56:37AM +0200, Robert Marklund wrote:

> +	/* Request regulator for vddvario */
> +	if (request && !pdata->regulator_vddvario) {
> +		pdata->regulator_vddvario = regulator_get(&pdev->dev,
> +				"vddvario");
> +		if (IS_ERR(pdata->regulator_vddvario)) {
> +			netdev_warn(ndev,
> +					"%s: Failed to get regulator '%s'\n",
> +					__func__, "vddvario");
> +			pdata->regulator_vddvario = NULL;
> +		}

No, this is broken - look at how other devices use the regulator API.
The driver should just request and use the regulators unconditionally
and let the stubbing and mapping facilities the API has deal with
ensuring that they always succeed.

As a side note the use of "pdata" as a name for the driver internal data
is really not helpful, pdata is traditionally the platform data passed
in by the machine (which would be even more broken).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html