netdev - RE: [PATCH] smsc911x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Oct 2011 16:13:47 +0200
From:	Robert MARKLUND <robert.marklund@...ricsson.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Steve Glendinning <steve.glendinning@...c.com>,
	Mathieu Poirer <mathieu.poirier@...aro.org>
Subject: RE: [PATCH] smsc911x: Add regulator support

> -----Original Message-----
> From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> Sent: den 17 oktober 2011 14:36
> To: Robert MARKLUND
> Cc: netdev@...r.kernel.org; Steve Glendinning; Mathieu Poirer
> Subject: Re: [PATCH] smsc911x: Add regulator support
> 
> On Mon, Oct 17, 2011 at 01:30:06PM +0200, Robert MARKLUND wrote:
> 
> You should fix your mail client to word wrap within paragraphs, I've
> reformatted it for legibility.  Also leave a blank line between
> paragraphs for the same reason.

I have tried but it's not as easy as it sounds :)
Does it look better now ?

> 
> > > No, this is broken - look at how other devices use the regulator API.
> > > The driver should just request and use the regulators unconditionally
> > > and let the stubbing and mapping facilities the API has deal with
> > > ensuring that they always succeed.
> 
> > So what you mean is get them and use them and ignore all the return
> > codes, and let the FW take care of the error handling ?
> 
> No, you should do what all the other drivers do and actually pay
> attention to the errors.  If we can't get power to the device that's a
> pretty serious problem and the driver ought  to fail.

Then I don't understand the initial comment.
Can you please elaborate that one.

> 
> > > As a side note the use of "pdata" as a name for the driver internal data
> > > is really not helpful, pdata is traditionally the platform data passed
> > > in by the machine (which would be even more broken).
> 
> > In the driver they have used this name for this structure throughout
> > the file I just followed that.  Personally I think it will be more
> > confusing to change the name of this structure in just this new
> > function.
> 
> I think someone should send a patch renaming the data throughout the
> entire driver, it's a terrible name for an embedded context.

I agree let this someone do it.
In the meanwhile isn't it best to keep the style that in the driver as of now.

/R
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html