netdev - Re: [net-next 2/6 v2] igb: Check if subordinate VFs are assigned to virtual machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318866838.5407.3.camel@Joe-Laptop>
Date:	Mon, 17 Oct 2011 08:53:58 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Greg Rose <gregory.v.rose@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Christian Benvenuti <benve@...co.com>,
	Sathya Perla <sathya.perla@...lex.com>,
	Dimitris Michailidis <dm@...lsio.com>,
	Jon Mason <jdmason@...zu.us>,
	James Smart <james.smart@...lex.com>
Subject: Re: [net-next 2/6 v2] igb: Check if subordinate VFs are assigned to
 virtual machines

On Mon, 2011-10-17 at 05:20 -0700, Jeff Kirsher wrote:
> From: Greg Rose <gregory.v.rose@...el.com>

Trivia:

> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
[]
> +	if (old_vfs) {
> +		dev_info(&pdev->dev, "%d pre-allocated VFs found - override "
> +			 "max_vfs setting of %d\n", old_vfs, max_vfs);
[]
> +		dev_err(&pdev->dev, "Unable to allocate memory for VF "
> +			"Data Storage\n");

The dev_err line isn't really necessary.
There is a generic allocation failure dump_stack.
Also, please don't split formats into multiple lines.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html