netdev - Re: [PATCH 6/7] mlx4_en: Adding rxhash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318902525.2571.24.camel@edumazet-laptop>
Date:	Tue, 18 Oct 2011 03:48:45 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 6/7] mlx4_en: Adding rxhash support

Le lundi 17 octobre 2011 à 22:18 +0200, Yevgeny Petrilin a écrit :
> Moving to Toeplitz function in RSS calculation.
> Reporting rxhash in skb.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>

>  	rss_context->flags = rss_mask;
> +	rss_context->hash_fn = 1;
> +	for (i = 0; i < 10; i++)
> +		rss_context->rss_key[i] = random32();
>  

Thats bit of a problem : Two NICS will have different seeds, and thus
provide different rxhash for a given flow. A bonding of two NICS will
not be able to provide a consistent rxhash.

drivers/net/ethernet/intel/igb/igb_main.c uses a static table to avoid
this problem.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html