netdev - Re: [PATCH] route:ip_rt_frag_needed always return unzero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318929797.2657.21.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 18 Oct 2011 11:23:17 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Gao feng <gaofeng@...fujitsu.com>
Cc:	davem@...emloft.net, kuznet@....inr.ac.ru, jmorris@...ei.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] route:ip_rt_frag_needed always return unzero

Le mardi 18 octobre 2011 à 15:04 +0800, Gao feng a écrit :
> int function ip_rt_frag_need,if peer is null,
> there is no need to do ipprot->err_handler.
> I am right?
> 
> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> ---
>  net/ipv4/route.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 075212e..6cde0fa 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1574,7 +1574,7 @@ unsigned short ip_rt_frag_needed(struct net *net, const struct iphdr *iph,
>  
>  		atomic_inc(&__rt_peer_genid);
>  	}
> -	return est_mtu ? : new_mtu;
> +	return est_mtu;
>  }
>  
>  static void check_peer_pmtu(struct dst_entry *dst, struct inet_peer *peer)

No idea why you want this, your changelog is a bit cryptic :)

Wont this bypass the raw_icmp_error(skb, protocol, info);
call in icmp_unreach() as well ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html