[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1319036228.2829.14.camel@bwh-desktop>
Date: Wed, 19 Oct 2011 15:57:08 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: Stephen Hemminger <shemminger@...tta.com>
Cc: Yevgeny Petrilin <yevgenyp@...lanox.co.il>,
Eric Dumazet <eric.dumazet@...il.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 6/7] mlx4_en: Adding rxhash support
On Tue, 2011-10-18 at 20:35 +0100, Ben Hutchings wrote:
[...]
> There was also a proposal a while back that we should try to make the
> hash symmetric w.r.t. RX and TX addresses, so that both directions of a
> flow through a router/bridge are aligned. I think this was to be done
> by repeating a 16-bit pattern across the key. Not sure whether that's
> worthwhile.
That also makes it relatively cheap to calculate in software, which
DragonflyBSD does:
http://gitweb.dragonflybsd.org/dragonfly.git/blob/master:/sys/net/toeplitz.c
http://gitweb.dragonflybsd.org/dragonfly.git/blob/master:/sys/net/toeplitz2.h
(the latter file appears to assume that in_addr_t/in_port_t are byte-
swapped i.e. the host is little-endian).
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists