netdev - Re: [PATCH] Disable TCP_DEBUG and FASTRETRANS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111019151600.67cd99e6@asterix.rh>
Date:	Wed, 19 Oct 2011 15:16:00 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	dpmcgee@...il.com, netdev@...r.kernel.org, kuznet@....inr.ac.ru,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Disable TCP_DEBUG and FASTRETRANS_DEBUG by default

On Mon, 17 Oct 2011 17:52:38 -0400 (EDT)
David Miller <davem@...emloft.net> wrote:

> From: Dan McGee <dpmcgee@...il.com>
> Date: Mon, 17 Oct 2011 15:25:24 -0500
> 
> > If these are truly debug options, they should be turned off by default
> > and can be tweaked if necessary. Fix one usage of the flag to use #if
> > instead of #ifdef so defining to zero is acceptable.
> > 
> > Signed-off-by: Dan McGee <dpmcgee@...il.com>
> 
> Illegal window shrinks are a serious issue, and the fact that everyone
> will see those messages by default and sometimes report them has been
> tremendously useful.
>

Agreed. I recently got bug report because of that message.  It is useful
and doesn't disturbe when network is fine, so please don't remove it.

fbl
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html