[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20111019.160009.1433033738937488070.davem@davemloft.net>
Date: Wed, 19 Oct 2011 16:00:09 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: afleming@...escale.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] phylib: Modify Vitesse RGMII skew settings
From: Andy Fleming <afleming@...escale.com>
Date: Thu, 13 Oct 2011 09:33:55 -0500
> The Vitesse driver was using the RGMII_ID interface type to determine if
> skew was necessary. However, we want to move away from using that
> interface type, as it's really a property of the board's PHY connection.
> However, some boards depend on it, so we want to support it, while
> allowing new boards to use the more flexible "fixups" approach. To do
> this, we extract the code which adds skew into its own function, and
> call that function when RGMII_ID has been selected.
>
> Another side-effect of this change is that if your PHY has skew set
> already, it doesn't clear it. This way, the fixup code can modify the
> register without config_init then clearing it.
>
> Signed-off-by: Andy Fleming <afleming@...escale.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists