netdev - Re: [PATCH net-next] tcp: use TCP_INIT_CWND in tcp_fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111019.165555.386071219519696637.davem@davemloft.net>
Date:	Wed, 19 Oct 2011 16:55:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: use TCP_INIT_CWND in tcp_fixup_sndbuf()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 14 Oct 2011 06:24:42 +0200

> Initial cwnd being 10 (TCP_INIT_CWND) instead of 3, change
> tcp_fixup_sndbuf() to get more than 16384 bytes (sysctl_tcp_wmem[1]) in
> initial sk_sndbuf
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks Eric.  Another reason to obliterate all magic constants :-)

> I believe a similar change in tcp_fixup_rcvbuf() is needed too.

And tcp_init_buffer_space() has a similar set of "4 * tp->advmss"
calculations.

And then some "2 * tp->advmss" cases, also having to do with window
clamping.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html