netdev - RE: [PATCH] ipvs: Remove unused variable "cs" from ip_vs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Oct 2011 12:37:51 +0200
From:	Hans Schillström <hans.schillstrom@...csson.com>
To:	Krzysztof Wilczynski <krzysztof.wilczynski@...ux.com>
CC:	Simon Horman <horms@...ge.net.au>,
	Patrick McHardy <kaber@...sh.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"pablo@...filter.org" <pablo@...filter.org>
Subject: RE: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave
 function.


>Hello,
>
>[...]
>> In my code there is another fix needed as well (todays net-next)
>> i.e.  usage od cs  "cs = ip_vs_set_state(cp, IP_VS_DIR_INPUT, skb, pd)"
>[...]
>
>Well spotted in terms of "net-next" branch and/or repository.
>
>In my case, I was working against "ipvs-next" using Simon's tree on
>github (I have made the fork when kernel.org facilities were not
>available at the time): https://github.com/horms/ipvs-next, and the
>code line you still appear to have in Dave's "net-next" (if that is
>the one) was amended in the following commit made against "ipvs-next":

Sorry, I didn't use that repo...
(waiting for ipvs return to kernel.org)

>
>
>commit 833656973cde30ba067a994c4802ebab6c9557ee
>Author: Simon Horman <horms@...ge.net.au>
>Date:   Fri Sep 16 14:11:49 2011 +0900
>
>    ipvs: Remove unused return value of protocol state transitions
>
>    Acked-by: Julian Anastasov <ja@....bg>
>    Acked-by Hans Schillstrom <hans@...illstrom.com>
>    Signed-off-by: Simon Horman <horms@...ge.net.au>
>    Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
>

>From what I can see Simon made a pull request and it was Acked by Pablo 28 Sep
http://www.spinics.net/lists/netfilter-devel/msg19742.html

I have not seen any output to Miller yet...
but I might be wrong in that case 


>
>It wasn't there when I went about cleaning unused declaration of "cs".
>I guess we have to make sure that everything between github (and
>repositories there) and kernel.org repositories like Dave's "net-next"
>align and holds water. Just by looking at some files, I can see that
>"net-next" is missing some commits.
>
>KW

Regards
Hans--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html