lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Oct 2011 11:14:46 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: David Miller <davem@...emloft.net> Cc: netdev <netdev@...r.kernel.org>, Rusty Russell <rusty@...tcorp.com.au>, "Michael S. Tsirkin" <mst@...hat.com>, virtualization@...ts.linux-foundation.org, Krishna Kumar <krkumar2@...ibm.com> Subject: [PATCH net-next] virtio_net: fix truesize underestimation We must account in skb->truesize, the size of the fragments, not the used part of them. Doing this work is important to avoid unexpected OOM situations. Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> CC: Rusty Russell <rusty@...tcorp.com.au> CC: "Michael S. Tsirkin" <mst@...hat.com> CC: virtualization@...ts.linux-foundation.org CC: Krishna Kumar <krkumar2@...ibm.com> --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index abbf34f..765ab9a 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -150,6 +150,7 @@ static void set_skb_frag(struct sk_buff *skb, struct page *page, skb->data_len += size; skb->len += size; + skb->truesize += PAGE_SIZE; skb_shinfo(skb)->nr_frags++; *len -= size; } @@ -287,7 +288,6 @@ static void receive_buf(struct net_device *dev, void *buf, unsigned int len) } hdr = skb_vnet_hdr(skb); - skb->truesize += skb->data_len; u64_stats_update_begin(&stats->syncp); stats->rx_bytes += skb->len; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists