netdev - Re: [PATCH net-next] myri10ge: fix truesize underestimation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMaF-rN8K3hDiwwqh_eGQ0nrxskn+7r9Rn_yDJ46aesKR77nbg@mail.gmail.com>
Date:	Thu, 20 Oct 2011 15:33:58 -0500
From:	Jon Mason <mason@...i.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Andrew Gallatin <gallatin@...i.com>
Subject: Re: [PATCH net-next] myri10ge: fix truesize underestimation

On Thu, Oct 20, 2011 at 3:10 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> skb->truesize must account for allocated memory, not the used part of
> it. Doing this work is important to avoid unexpected OOM situations.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Acked-by: Jon Mason <mason@...i.com>

> CC: Jon Mason <mason@...i.com>
> ---
>  drivers/net/ethernet/myricom/myri10ge/myri10ge.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
> index c970a48..0778edc 100644
> --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
> +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
> @@ -1210,7 +1210,6 @@ myri10ge_rx_skb_build(struct sk_buff *skb, u8 * va,
>        struct skb_frag_struct *skb_frags;
>
>        skb->len = skb->data_len = len;
> -       skb->truesize = len + sizeof(struct sk_buff);
>        /* attach the page(s) */
>
>        skb_frags = skb_shinfo(skb)->frags;
> @@ -1385,6 +1384,8 @@ myri10ge_rx_done(struct myri10ge_slice_state *ss, int len, __wsum csum,
>        if (skb_frag_size(&skb_shinfo(skb)->frags[0]) <= 0) {
>                skb_frag_unref(skb, 0);
>                skb_shinfo(skb)->nr_frags = 0;
> +       } else {
> +               skb->truesize += bytes * skb_shinfo(skb)->nr_frags;
>        }
>        skb->protocol = eth_type_trans(skb, dev);
>        skb_record_rx_queue(skb, ss - &mgp->ss[0]);
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html