netdev - Re: IPsec performance bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111021125429.c84610ac.kim.phillips@freescale.com>
Date:	Fri, 21 Oct 2011 12:54:29 -0500
From:	Kim Phillips <kim.phillips@...escale.com>
To:	"Yan, Zheng" <zheng.z.yan@...ux.intel.com>
CC:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<hirofumi@...l.parknet.co.jp>
Subject: Re: IPsec performance bug

On Fri, 21 Oct 2011 16:28:30 +0800
"Yan, Zheng" <zheng.z.yan@...ux.intel.com> wrote:

> On Thu, Oct 20, 2011 at 10:22 AM, Kim Phillips
> <kim.phillips@...escale.com> wrote:
> > (b) any ideas how to fix?  I don't know much about routing
> > internals, but in ip_route_input_common(), if I remove the input
> > interface comparison (rth->rt_route_iif ^ iif), I get some
> > performance back, but the system becomes unstable (it's booted over
> > nfs).
> 
> Looks like xfrm4_fill_dst() reset rt->rt_route_iif to 0, it makes the
> comparison (rth->rt_route_iif ^ iif) in
> ip_route_input_common() return false.
> 
> Please try patch below. It improves the performance of 3.1-rc10
> kernel.

yes, thanks, ~50kpps performance is restored when applying this diff
to current net-next.

> (I'm not sure the patch is harmless)

the system appears to be more stable, but this is still concerning.

Kim

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html