netdev - Re: [PATCH] jme: fix irq storm after suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Oct 2011 18:39:22 +0530
From:	Mohammed Shafi <shafi.wireless@...il.com>
To:	Clemens Buchacher <drizzd@....at>
Cc:	Guo-Fu Tseng <cooldavid@...ldavid.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adrian Chadd <adrian@...ebsd.org>
Subject: Re: [PATCH] jme: fix irq storm after suspend/resume

On Sat, Oct 22, 2011 at 6:26 PM, Clemens Buchacher <drizzd@....at> wrote:
> If the device is down during suspend/resume, interrupts are enabled
> without a registered interrupt handler, causing a storm of
> unhandled interrupts until the IRQ is disabled because "nobody
> cared".

thank you so much for fixing this. incredible persistence from your side!

>
> Instead, check that the device is up before touching it in the
> suspend/resume code.
>
> Fixes https://bugzilla.kernel.org/show_bug.cgi?id=39112
>
> Helped-by: Adrian Chadd <adrian@...ebsd.org>
> Helped-by: Mohammed Shafi <shafi.wireless@...il.com>
> Signed-off-by: Clemens Buchacher <drizzd@....at>
> ---
>
> Unfortunately, bugzilla.kernel.org is still down. There is at least
> one other person who reported the issue, and I don't have their
> email address. So for now, I am the only one who tested this fix.
>
> The patch applies to current tip (2efd7c0) of Linus' tree. I also
> tested it based on v3.0 and it worked the same.
>
> Many thanks to Adrian and Mohammed for helping me debug this issue.
> See this thread for the history:
>  http://mid.gmane.org/20110827113253.GA1444@ecki
>
>  drivers/net/jme.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/jme.c b/drivers/net/jme.c
> index 3ac262f..7a8a3b6 100644
> --- a/drivers/net/jme.c
> +++ b/drivers/net/jme.c
> @@ -3131,6 +3131,9 @@ jme_suspend(struct device *dev)
>        struct net_device *netdev = pci_get_drvdata(pdev);
>        struct jme_adapter *jme = netdev_priv(netdev);
>
> +       if (!netif_running(netdev))
> +               return 0;
> +
>        atomic_dec(&jme->link_changing);
>
>        netif_device_detach(netdev);
> @@ -3171,6 +3174,9 @@ jme_resume(struct device *dev)
>        struct net_device *netdev = pci_get_drvdata(pdev);
>        struct jme_adapter *jme = netdev_priv(netdev);
>
> +       if (!netif_running(netdev))
> +               return 0;
> +
>        jme_clear_pm(jme);
>        jme_phy_on(jme);
>        if (test_bit(JME_FLAG_SSET, &jme->flags))
> --
> 1.7.7
>
>



-- 
shafi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html