netdev - Re: [patch net-next V2] net: introduce ethernet teaming device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1319380668.27507.19.camel@edumazet-laptop>
Date:	Sun, 23 Oct 2011 16:37:48 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	bhutchings@...arflare.com, shemminger@...tta.com, fubar@...ibm.com,
	andy@...yhouse.net, tgraf@...radead.org, ebiederm@...ssion.com,
	mirqus@...il.com, kaber@...sh.net, greearb@...delatech.com,
	jesse@...ira.com, fbl@...hat.com, benjamin.poirier@...il.com,
	jzupka@...hat.com
Subject: Re: [patch net-next V2] net: introduce ethernet teaming device

Le dimanche 23 octobre 2011 à 14:51 +0200, Jiri Pirko a écrit :

> Yes. And team->mode_ops.receive can change only after synchronize_rcu is
> done. It's not possible it changes within the window you are talking about.

If it was true, you would not need the synchronize_rcu() call you added
in __team_change_mode() :


----------------------------------------------------------------------

static int __team_change_mode(struct team *team,
                             const struct team_mode *new_mode)
{
       /* Check if mode was previously set and do cleanup if so */
       if (team->mode_kind) {
               void (*exit_op)(struct team *team) = team->mode_ops.exit;

               /* Clear ops area so no callback is called any longer */
               team_mode_ops_clear(&team->mode_ops);

               synchronize_rcu();

               if (exit_op)
                       exit_op(team);


-----------------------------------------------------------------------

So the question is : Why do you have this synchronize_rcu() call here ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html