netdev - Re: [PATCH net-next] bonding: fix wrong port enabling in 802.3ad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 23 Oct 2011 08:04:09 -0700
From:	Kartik Chandran <kartik@...stanetworks.com>
To:	netdev@...r.kernel.org
Cc:	Sriram Chidambaram <srichida@...stanetworks.com>,
	Hugh Holbrook <holbrook@...stanetworks.com>
Subject: Re: [PATCH net-next] bonding: fix wrong port enabling in 802.3ad

By a strange coincidence, we ran into this exact issue last week while
experimenting with the "standby" state, where we discovered that the
current implementation in bond_3ad does not pay attention to the Mux
SM state when deciding to enable a slave port for transmission, which
causes misbehavior in forwarding on the partner side.

Since the question was raised on the thread about what the 802.3ad
spec says in this respect, we can confidently answer that the spec
clearly mandates that the aggregator should include a port for
transmission only when it goes to DISTRIBUTING ( in independent
control  mode) and COLLECTING+DISTRIBUTING (in coupled mode).

We are testing this extensively right now, so I'm happy to try out
this patch and report back with findings.

-Kartik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html