netdev - Re: [PATCH net-next] w5300: add WIZnet W5300 Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111024.182142.2299822581628382143.davem@davemloft.net>
Date:	Mon, 24 Oct 2011 18:21:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kth3321@...il.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	romieu@...zoreil.com, suhwan@...net.co.kr, bongbong@...net.co.kr
Subject: Re: [PATCH net-next] w5300: add WIZnet W5300 Ethernet driver

From: Taehun Kim <kth3321@...il.com>
Date: Sat, 22 Oct 2011 17:41:56 +0900

> +struct wiz_private {
> +	void __iomem *base;
> +	struct net_device *dev;
> +	u8 rxbuf_conf[MAX_SOCK_NUM];
> +	u8 txbuf_conf[MAX_SOCK_NUM];
> +	struct net_device_stats stats;
> +	struct napi_struct napi;
> +	spinlock_t lock;
> +	u32 msg_enable;
> +};

You don't need to have a private net_device_stats, just use the
one in struct net_device, and then you can also get rid of your
private ->ndo_get_stats() method.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html