netdev - Re: [PATCH] caif: fix cfcnfg_add_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111024.183623.551713905402332500.davem@davemloft.net>
Date:	Mon, 24 Oct 2011 18:36:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jj@...osbits.net
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	sjur.brandeland@...ricsson.com
Subject: Re: [PATCH] caif: fix cfcnfg_add_phy_layer() leaks

From: Jesper Juhl <jj@...osbits.net>
Date: Tue, 25 Oct 2011 00:01:00 +0200 (CEST)

> There are two locations where we 'goto out' after having allocated
> memory for 'phyinfo' but have not yet assigned it to anything. At the
> 'out:' label we'll exit from the function and 'phyinfo' will go out of
> scope and thus we leak the memory we allocated.
> 
> This patch frees the memory before jumping to 'out:', thus fixing the
> leaks.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

The code in net-next looks a lot different, please see if the issue
still exists there and resubmit if so, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html