netdev - Re: [PATCH] net: make bonding slaves honour master's skb->priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111025110808.27db8487@asterix.rh>
Date:	Tue, 25 Oct 2011 11:08:08 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	Maciej Żenczykowski <zenczykowski@...il.com>
Cc:	Maciej Żenczykowski <maze@...gle.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: make bonding slaves honour master's skb->priority

On Mon, 24 Oct 2011 22:04:16 -0700
Maciej Żenczykowski <zenczykowski@...il.com> wrote:

> From: Maciej Żenczykowski <maze@...gle.com>
> 
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> ---
>  drivers/net/bonding/bond_main.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c
> b/drivers/net/bonding/bond_main.c index 41430ba..2cbc2f8 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond,
> struct sk_buff *skb, struct net_device *slave_dev)
>  {
>  	skb->dev = slave_dev;
> -	skb->priority = 1;
>  
>  	skb->queue_mapping = bond_queue_mapping(skb);
>  

I tripped on it few times and never understood why we
were fixing the priority at this point.
thanks,

Acked-by: Flavio Leitner <fbl@...hat.com>
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html