netdev - RE: [PATCH 2/2] net/smsc911x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2B1D156D95AE9B4EAD379CB9E465FE7324AC5ED8E4@EXDCVYMBSTM005.EQ1STM.local>
Date:	Wed, 26 Oct 2011 12:57:58 +0200
From:	Robert MARKLUND <robert.marklund@...ricsson.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Steve Glendinning <steve.glendinning@...c.com>,
	Mathieu Poirer <mathieu.poirier@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: RE: [PATCH 2/2] net/smsc911x: Add regulator support

> -----Original Message-----
> From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> Sent: den 26 oktober 2011 10:39
> To: Linus WALLEIJ
> Cc: netdev@...r.kernel.org; Steve Glendinning; Mathieu Poirer; Robert MARKLUND; Linus Walleij
> Subject: Re: [PATCH 2/2] net/smsc911x: Add regulator support
> 
> On Wed, Oct 26, 2011 at 10:05:56AM +0200, Linus Walleij wrote:
> 
> > +	/* enable/disable regulator for vddvario */
> > +	if (pdata->regulator_vddvario) {
> 
> This has the same issue as last time - if you've got conditional code
> like this in the body of the driver something is going wrong.  Unless
> the supply is genuinely optional and might not be physically present on
> some systems the driver should fail if it can't get it.  The regulator
> API will stub itself out when not in use.

My mistake I didn't remember to remove them.
If you review the rest of the code you see that the driver will not start if we can't get the regulators.
So that code will never run in the case where pdata->regulator_vddvario == 0.

So this will leave all the platforms using this driver and have full constraints to fail to start this driver.
If they don't create dummy regulators.

Just so we are on the clear with that.

/R


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html