netdev - Re: [PATCH net-next] ipv4: use IS_ENABLED() macro to cleanup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Oct 2011 08:34:34 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv4: use IS_ENABLED() macro to cleanup code

Le mardi 25 octobre 2011 à 19:30 -0400, David Miller a écrit :

> net/ipv4/ip_sockglue.c: In function ‘do_ip_setsockopt’:
> net/ipv4/ip_sockglue.c:523:29: error: ‘LOOPBACK4_IPV6’ undeclared (first use in this function)
> net/ipv4/ip_sockglue.c:523:29: note: each undeclared identifier is reported only once for each function it appears in
> 
> This fails because ip_sockglue.c guards the net/transp_v6.h header
> inclusion with a real CPP guard.

Yep, it seems compiler was not able to perform optimisation of dead
code.

        if (IS_ENABLED(CONFIG_IPV6) &&
            (sk->sk_family == PF_INET ||
             (!((1 << sk->sk_state) &
                (TCPF_LISTEN | TCPF_CLOSE)) &&
             inet->inet_daddr != LOOPBACK4_IPV6))) {

Never mind, this will wait 3.3 :)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html