netdev - Re: [PATCH 2/3] stmmac: fix NULL pointer dereference in capabilities fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EA8EDC7.7020305@st.com>
Date:	Thu, 27 Oct 2011 07:36:07 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, keguang.zhang@...il.com,
	Angus Clark <angus.clark@...com>
Subject: Re: [PATCH 2/3] stmmac: fix NULL pointer dereference in capabilities
 fixup

On 10/27/2011 12:26 AM, Ben Hutchings wrote:
> On Wed, 2011-10-26 at 15:55 +0200, Giuseppe CAVALLARO wrote:
>> From: Angus Clark <angus.clark@...com>
>>
>> Signed-off-by: Angus Clark <angus.clark@...com>
>> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
>> ---
>>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index fcdd5a2..f77eaa6 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -325,7 +325,7 @@ static int stmmac_init_phy(struct net_device *dev)
>>  	    (interface == PHY_INTERFACE_MODE_RMII))) {
>>  		phydev->supported &= (PHY_BASIC_FEATURES | SUPPORTED_Pause |
>>  				      SUPPORTED_Asym_Pause);
>> -		priv->phydev->advertising = priv->phydev->supported;
>> +		priv->phydev->advertising = phydev->supported;
> 
> How can this fix the bug?  You mean:
> 
> 		phydev->advertising = phydev->supported;

Ben, you are rigth.
I did a mistake importing the patch from Angus.

I'm fixing and resending it again.

Thanks and Sorry
Peppe

> 
> Ben.
> 
>>  	}
>>  
>>  	/*
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html