netdev - Re: drivers/net/ethernet/apple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1319701536.10258.74.camel@jtkirshe-mobl>
Date:	Thu, 27 Oct 2011 00:45:35 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: drivers/net/ethernet/apple

On Wed, 2011-10-26 at 22:16 -0700, Geert Uytterhoeven wrote:
> Hi Jeff,
> 
> On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven
> <geert@...ux-m68k.org> wrote:
> > drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal
> Semiconductor
> > (Now Cirrus Logic) CS89[02]0, so it belongs in
> drivers/net/ethernet/cirrus,
> > next to cs89x0.c.
> 
> And on the first -next run since its inclusion:
> 
> | drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
> such file or directory
> 
> it needs the (shared) header file which is in
> drivers/net/ethernet/cirrus/.
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/ 

Ah, yeah, now it is coming back to me why I placed cs89x0.[ch] in the
drivers/net/ethernet/apple/ because it was grouped with the "common"
drivers.  The intent was to group drivers that use common code together.

I can put together a patch to fix this if you are not able to.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)