netdev - Re: [PATCH 1/2] bonding: Doesn't support IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1319878812.2586.10.camel@edumazet-laptop>
Date:	Sat, 29 Oct 2011 11:00:12 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	John <linux@...2.net>, netdev@...r.kernel.org, andy@...yhouse.net
Subject: Re: [PATCH 1/2] bonding: Doesn't support IPv6

Le samedi 29 octobre 2011 à 10:49 +0200, Eric Dumazet a écrit :
> Le samedi 29 octobre 2011 à 09:55 +0200, Michał Mirosław a écrit :
> > 2011/10/29 John <linux@...2.net>:
> > > --- a/drivers/net/bonding/bond_main.c   2011-04-19 11:18:48.000000000 -0700
> > > +++ b/drivers/net/bonding/bond_main.c   2011-10-27 11:26:20.000000000 -0700
> > [...]
> > > +               v6hash = (v6hash >> 16) ^ (v6hash >> 8) ^ v6hash;
> > 
> > This XORs in only 3 of 4 bytes, and assuming count > 256 (its unlikely
> > you have more than 256 slaves in bond) the most significant byte is
> > wasted. It should be:
> > 
> > v6hash ^= v6hash >> 16;
> > v6hash ^= v6hash >> 8;
> > 
> > Same for IPv4 part.
> > 
> > OTOH, if that was your intention, then the description in your mail was wrong.
> > 
> 
> Same end result :)
> 

Oh well, not exactly, there was a reason for using two different C
instructions ;)

ALso the modulo is expensive...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html