netdev - Re: [patch 1/1] net/netfilter/nf_conntrack_netlink.c: fix Oops on container destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111101080715.GA4268@1984>
Date:	Tue, 1 Nov 2011 09:07:15 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	akpm@...ux-foundation.org
Cc:	kaber@...sh.net, davem@...emloft.net, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, alex@...x.org.uk,
	stable@...nel.org, stable@...r.kernel.org
Subject: Re: [patch 1/1] net/netfilter/nf_conntrack_netlink.c: fix Oops on
 container destroy

On Mon, Oct 31, 2011 at 02:33:12PM -0700, akpm@...ux-foundation.org wrote:
> diff -puN net/netfilter/nf_conntrack_netlink.c~net-netfilter-nf_conntrack_netlinkc-fix-oops-on-container-destroy net/netfilter/nf_conntrack_netlink.c
> --- a/net/netfilter/nf_conntrack_netlink.c~net-netfilter-nf_conntrack_netlinkc-fix-oops-on-container-destroy
> +++ a/net/netfilter/nf_conntrack_netlink.c
> @@ -570,6 +570,11 @@ ctnetlink_conntrack_event(unsigned int e
>  		return 0;
>  
>  	net = nf_ct_net(ct);
> +
> +	/* container deinit, netlink may have died before death_by_timeout */
> +	if (!net->nfnl)
> +		return 0;
> +

This patch is a workaround and it is incomplete (it doesn't include
the expectation part). The correct fix requires to finish container
support for nfnetlink, which seems incomplete.

I was expecting some feedback from Alexey Dobriyan with no success.

If we apply this, we'll have to apply similar workaround in other
parts of the code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html