netdev - Re: [PATCH] r8169: Fix WOL in power down case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <loom.20111101T174532-579@post.gmane.org>
Date:	Tue, 1 Nov 2011 17:28:46 +0000 (UTC)
From:	Stefan Becker <chemobejk@...il.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: Fix WOL in power down case

Marc Ballarin <ballarin.marc <at> gmx.de> writes:
> 
> On Sun, 9 Oct 2011 13:54:38 +0200
> Francois Romieu <romieu <at> fr.zoreil.com> wrote:
> 
> > ...
> > Moreover, the patch duplicates a chunk of conditional code:
> > 1) it bloats the driver (ok, we have seen worse...).
> > 2) you can bet that both instances won't be updated if / when
> >    RTL_GIGA_MAC_VER_xy appears.
> 
> I thought so 
> 
> > 
> > The patch below should fix it.
> 
> Yes, it works fine here. Thanks a lot.
> 

I just upgraded to Fedora 16 with Kernel 3.1.0 and WoL stopped working in the
power down case on my R8168 :-(

[    8.557372] r8169 0000:02:00.0: eth0: RTL8168c/8111c at 0xf809a000,
00:1f:d0:5a:22:77, XID 1c4000c0 IRQ 43

02:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
RTL8111/8168B PCI Express Gigabit Ethernet controller [10ec:8168] (rev 02)

I've checked the SRPM and git commit 649b3b8c4e868 with the fix discussed here
is included. It obviously doesn't work for my HW.

According to the code the combination "RTL8168c/8111c" means RTL_GIGA_MAC_VER_19
to _22, so the code changes in the fix commit don't apply to them. Could it be
that the fix doesn't cover all the necessary HW?

Regards,

           Stefan

PS: Please CC me in your reply, as I don't read the mailing list.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html