netdev - Re: [PATCH] ipv4: fix ipsec forward performance regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Nov 2011 18:50:22 -0500
From:	Kim Phillips <kim.phillips@...escale.com>
To:	<stable@...nel.org>
CC:	<eric.dumazet@...il.com>, <zheng.z.yan@...el.com>,
	<netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] ipv4: fix ipsec forward performance regression

On Mon, 24 Oct 2011 03:02:03 -0400
David Miller <davem@...emloft.net> wrote:

> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Sun, 23 Oct 2011 11:03:10 +0200
> 
> > Le dimanche 23 octobre 2011 à 15:58 +0800, Yan, Zheng a écrit :
> >> There is bug in commit 5e2b61f(ipv4: Remove flowi from struct rtable).
> >> It makes xfrm4_fill_dst() modify wrong data structure.
> >> 
> >> Signed-off-by: Zheng Yan <zheng.z.yan@...el.com>
>  ...
> > Reported-by: Kim Phillips <kim.phillips@...escale.com>
> > 
> > Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Applied, thanks everyone.

To: <stable@...nel.org>

-stable maintainers, please consider the following two upstream
commits for inclusion in upcoming v3.0.x [1] stable releases:

v3.0.8 plus this:

upstream commit b73233960a59ee66e09d642f13d0592b13651e94
(ipv4: fix ipsec forward performance regression)

increases IPSec fwding performance from 0.2kpps to ~3.5kpps.

Adding this:

upstream commit aa1c366e4febc7f5c2b84958a2dd7cd70e28f9d0
(net: Handle different key sizes between address families in flow
cache)

to that, brings it back up to 2.6.38 levels, i.e., ~44kpps.

note that for v2.6.39.4 (.39 is the first kernel version with the
40->0.2kpps regression), commit b732339 depends on a slew of
commits, presumably ending with commit 5e2b61f: ipv4: Remove flowi
from struct rtable.

However it appears commit aa1c366e alone will restore almost all
the performance (~42kpps) on that kernel version.

So to summarize, please cherry-pick:

v2.6.39.x: aa1c366: net: Handle different key sizes between address families in flow cache
v3.0.x: aa1c366: net: Handle different key sizes between address families in flow cache
v3.0.x: b732339: ipv4: fix ipsec forward performance regression
v3.1.x: b732339: ipv4: fix ipsec forward performance regression

[All figures are based on a p2020ds board configured to rx, encrypt
and forward 64-byte packets.]

Thanks,

Kim

[1] initial kernel in long-term stable series for the embedded
industry (http://lwn.net/Articles/464834/)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html