netdev - Re: [PATCH] net: ucc_geth, increase no. of HW RX descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111102.005650.1042174729471815202.davem@davemloft.net>
Date:	Wed, 02 Nov 2011 00:56:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Joakim.Tjernlund@...nsmode.se
Cc:	avorontsov@...mvista.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ucc_geth, increase no. of HW RX descriptors

From: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
Date: Tue, 25 Oct 2011 15:17:10 +0200

> In a busy network we see ucc_geth is dropping RX pkgs every now
> and then. Increase the first RX queues HW descriptors from
> 16 to 32 to deal with this.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>

1) This patch doesn't apply, because in the current tree this
   dirver lives under drivers/net/ethernet/freescale/ not
   drivers/net

2) Why not increase RX_BD_RING_LEN and thus all the ring sizes,
   is there a special reason only the first ring's size should
   be increased?

   Because the way you've made this change is confusing, someone
   will see RX_BD_RING_LEN's definition and believe that this is
   the size of the primary ring unless they happen to notice
   how .bdRingLenRx is initialized in this special way.

Thus, this patch needs changes before it can even be considered
for inclusion.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html