netdev - Re: [PATCH] IPv6 - support for NLM_F_* flags at IPv6 routing requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANhJrGMeE7qsNBY6Sd2+tUWOezEv=Grc4uoArqAz=Ru4Me8Dsg@mail.gmail.com>
Date:	Wed, 2 Nov 2011 08:28:20 +0200
From:	Maz The Northener <mazziesaccount@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Matti Vaittinen <matti.vaittinen@....com>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] IPv6 - support for NLM_F_* flags at IPv6 routing requests

On Tue, Nov 1, 2011 at 11:43 PM, Stephen Hemminger
<shemminger@...tta.com> wrote:
> On Tue, 01 Nov 2011 16:22:27 +0200
> Matti Vaittinen <matti.vaittinen@....com> wrote:
>
>>
>> +#define RT6_CANT_CREATE ((int)-1)
>>  #define RT6_DEBUG 2
>
> Rather than introduce a new error flag, why not convert the code
> to use the kernel standard PTR_ERR() macros?
> --

Thanks for comment Stephen, I admitt I felt there was something rotten
in adding a new define. And as to why not use PTR_ERR() - I did not
know about such a facility. I'll fix this to be

return ERR_PTR(-ENOENT);

and at calling function check for
if (PTR_ERR(fn) == -ENOENT)

I guess that is correct way?

And finally couple of questions about sending patches (I'm a new guy
in this "house" of yours):
Is it Ok to add patch as attachment? I'm having difficulties in using
a client which allows sending plain text.
And is it Ok to create patch against linux 3.1-rc4? I've never used
git, and thus obtaining 3.1-rc4 from kernel.org is the easiest way for
me.

--Matti Vaittinen
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html