| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20111103143752.GB7718@e-circ.dyndns.org> Date: Thu, 3 Nov 2011 15:37:52 +0100 From: Kurt Van Dijck <kurt.van.dijck@....be> To: Oliver Hartkopp <socketcan@...tkopp.net> Cc: Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org, linux-can@...r.kernel.org, Reuben.Dowle@...ico.com Subject: Re: [PATCH 0/2] clean up tx_bytes accounting On Thu, Nov 03, 2011 at 03:27:38PM +0100, Oliver Hartkopp wrote: > On 03.11.2011 11:42, Marc Kleine-Budde wrote: > > > On 11/03/2011 11:03 AM, Kurt Van Dijck wrote: > >> On Thu, Nov 03, 2011 at 10:47:53AM +0100, Marc Kleine-Budde wrote: > >>> Hello, > >>> > >>> what about turning can_get_echo_skb() into a helper function which returns the number > >>> of tx'ed bytes. > >> That would work. > >> > >> Next step would be to do the statistics inside can_get_echo_skb(), but that's > >> affecting all drivers using it ... > >> Kurt > > > > Interesting idea > > > Yes, but then the name of the function is not appropriate anymore. > > The return value for can_get_echo_skb() gives a silent improvement that can be > adopted by CAN drivers by the time. But hiding more functionality inside this > function may lead to misunderstandings. That's what I described with the obscure phrase "..." :-) Marc's proposed patch is indeed easier to digest at the time. > Regards, Kurt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists