netdev - Re: [PATCH 0/2] clean up tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EB2AD3B.6030207@pengutronix.de>
Date:	Thu, 03 Nov 2011 16:03:23 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Oliver Hartkopp <socketcan@...tkopp.net>, netdev@...r.kernel.org,
	linux-can@...r.kernel.org, Reuben.Dowle@...ico.com
Subject: Re: [PATCH 0/2] clean up tx_bytes accounting

On 11/03/2011 03:37 PM, Kurt Van Dijck wrote:
> On Thu, Nov 03, 2011 at 03:27:38PM +0100, Oliver Hartkopp wrote:

>>>> Next step would be to do the statistics inside can_get_echo_skb(), but that's
>>>> affecting all drivers using it ...
>>>> Kurt
>>>
>>> Interesting idea
>>
>>
>> Yes, but then the name of the function is not appropriate anymore.
>>
>> The return value for can_get_echo_skb() gives a silent improvement that can be
>> adopted by CAN drivers by the time. But hiding more functionality inside this
>> function may lead to misunderstandings.
> That's what I described with the obscure phrase "..." :-)
> 
> Marc's proposed patch is indeed easier to digest at the time.

+1, I'll repost my fixed branch. Let's first integrate that one.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (263 bytes)