netdev - Re: [PATCH] fsl_pq_mdio: Clean up tbi address configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111103.224428.2087649126851525828.davem@davemloft.net>
Date:	Thu, 03 Nov 2011 22:44:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	afleming@...escale.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] fsl_pq_mdio: Clean up tbi address configuration

From: Andy Fleming <afleming@...escale.com>
Date: Thu, 3 Nov 2011 16:54:11 -0500

> The code for setting the address of the internal TBI PHY was
> convoluted enough without a maze of ifdefs. Clean it up a bit
> so we allow the logic to fail down to -ENODEV at the end of
> the if/else ladder, rather than using ifdefs to repeat the same
> failure code over and over.
> 
> Also, remove the support for the auto-configuration. I'm not aware of
> anyone using it, and it ends up using the bus mutex before it's been
> initialized.
> 
> Signed-off-by: Andy Fleming <afleming@...escale.com>

Cleanups of this nature are not appropriate to submit at this time,
please wait until the net-next tree becomes active again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html