netdev - Re: bridge: allow forwarding LLDP frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF5U64A0R0o2duJYU=7w-G77dfgzoeWkeLKwt21WJeABhwf8VQ@mail.gmail.com>
Date:	Fri, 4 Nov 2011 06:50:19 -0700
From:	Ed Swierk <eswierk@...switch.com>
To:	Nick Carter <ncarter100@...il.com>
Cc:	shemminger@...tta.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: bridge: allow forwarding LLDP frames

On Thu, Nov 3, 2011 at 3:17 PM, Nick Carter <ncarter100@...il.com> wrote:
> The reason the group fwd mask was introduced was to make the bridge
> forward link local group addresses.  This is non standards based
> behaviour.  The point of the group fwd mask is so that users can have
> non standard bridging behaviour.
>
> I don't understand why the recent commit includes blocking the user
> from choosing to forward certain groups because it breaks standards ?
> The default mask of 0 is standards based behaviour.  If the user sets
> it to anything other than 0 then they want non standards based
> behaviour.
>
> In my view the behaviour now is very confusing for the user.  802.1X
> is allowed to be forwarded but LLDP forwarding is rejected ?
>
> The group fwd mask should be allowed to be set to any value.  This
> would give flexible and predictable behaviour to the user.
>
> I think we should assume users know the behaviour they require and
> BR_GROUPFWD_RESTRICTED should be removed from the codebase.

+1

It doesn't make sense to go out of our way to forbid users from
enabling forwarding of three magic addresses. Removing the restriction
would simplify the code and simplify the behavior.

--Ed
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html