netdev - Re: [PATCH] net: add calxeda xgmac ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EB45071.8000406@gmail.com>
Date:	Fri, 04 Nov 2011 15:52:01 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	netdev@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] net: add calxeda xgmac ethernet driver

Grant,

On 11/04/2011 11:57 AM, Grant Likely wrote:
> On Wed, Oct 26, 2011 at 10:56 PM, Rob Herring <robherring2@...il.com> wrote:
>> From: Rob Herring <rob.herring@...xeda.com>
>>
>> Add support for the XGMAC 10Gb ethernet device in the Calxeda Highbank
>> SOC.
>>
>> Signed-off-by: Rob Herring <rob.herring@...xeda.com>
> 
> Sinker question: is this a driver for an entirely new GMAC device
> (designed from scratch) or is it based on an existing IP block?
> 

Of course I'd rather use a existing driver. It is a new IP block.

>> +/**
>> + * xgmac_init - Entry point for the driver
>> + * Description: This function is the entry point for the driver.
>> + */
>> +static int __init xgmac_init(void)
>> +{
>> +       return platform_driver_register(&xgmac_driver);
>> +}
>> +module_init(xgmac_init);
>> +
>> +/**
>> + * xgmac_cleanup_module - Cleanup routine for the driver
>> + * Description: This function is the cleanup routine for the driver.
>> + */
>> +static void __exit xgmac_exit(void)
>> +{
>> +       platform_driver_unregister(&xgmac_driver);
>> +}
>> +module_exit(xgmac_exit);
> 
> You can drop some boilerplate with module_platform_driver() now.

Okay.

Rob
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html