netdev - Re: [net-next 03/10] seeq: Move the SEEQ drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1320442974.5386.14.camel@jtkirshe-mobl>
Date:	Fri, 04 Nov 2011 14:42:53 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Joe Perches <joe@...ches.com>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	Hamish Coleman <hamish@....apana.org.au>
Subject: Re: [net-next 03/10] seeq: Move the SEEQ drivers

On Fri, 2011-11-04 at 14:25 -0700, Russell King - ARM Linux wrote:
> On Fri, Nov 04, 2011 at 11:16:07PM +0200, Joe Perches wrote:
> > On Fri, 2011-11-04 at 17:24 +0000, Russell King - ARM Linux wrote:
> > > Okay, this is the only patch I saw (for the SEEQ drivers), but I notice
> > > that more of the ARM drivers have moved.  The result is not nice.  Or
> > > even workable.
> > > 
> > > While looking for my ether1, ether3 and etherh drivers in Kconfig, I
> > > enable every option which is presented to me under the new 'ethernet
> > > drivers' stuff.  I'm offered my ether3 driver under the SEEQ stuff -
> > > that's fine.  But what about the rest?
> > []
> > > While I realise this is a big change, and bugs like this are likely, it
> > > would've been nice to be copied on more of the patches which affect
> > > drivers I maintain.
> > 
> > Hi Russell.
> > 
> > What drivers in drivers/net do you maintain?
> > 
> > I believe this is the list in MAINTAINERS for you:
> > 
> > ARM/EBSA110 MACHINE SUPPORT
> > F:      drivers/net/ethernet/amd/am79c961a.*
> > ARM/RISCPC ARCHITECTURE
> > F:      drivers/net/ethernet/i825xx/ether1*
> > F:      drivers/net/ethernet/seeq/ether3*
> > 
> > Are there others? If yes, what are they?
> 
> If that's what's in mainline, then etherh has been dropped from that
> list through this move.  It's drivers/net/ethernet/8390/etherh*, so
> that needs adding back for "ARM/RISCPC ARCHITECTURE".
> 
> It was correct - below seems to be what happened...
> 
> commit 115978859272b958366d4a08c99a24f9625fa663
> Author: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date:   Wed Jul 13 15:38:08 2011 -0700
> 
>     i825xx: Move the Intel 82586/82593/82596 based drivers
> 
> @@ -1014,7 +1014,7 @@ F:        arch/arm/include/asm/hardware/ioc.h
>  F:     arch/arm/include/asm/hardware/iomd.h
>  F:     arch/arm/include/asm/hardware/memc.h
>  F:     arch/arm/mach-rpc/
> -F:     drivers/net/arm/ether*
> +F:     drivers/net/arm/ether3*
> 
> That change was probably correct at the time, because this one which
> came before it:
> 
> commit 644570b830266ff33ff5f3542b9c838f93a55ea6
> Author: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date:   Sat Apr 2 06:20:12 2011 -0700
> 
>     8390: Move the 8390 related drivers
> 
> which moved the etherh driver without updating MAINTAINERS for that
> change.

This was my bad.  There was a lot of discussion and shuffling of drivers
early on to make sure we have the drivers in the right location, and I
initially had all the drivers/net/arm/ether* drivers in the same
location.  I can put together a patch to resolve this if no one has one
in the works.

Sorry about that Russell.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)